Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update artifact actions to v4 #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshuarli
Copy link
Member

Uses artifacts/merge to merge together multiple artifacts from different jobs into the single one named github.sha that craft expects.

Summarily, upload-artifact v3 is deprecated but v4 doesn't support mutating an artifact with the name name by uploading different filepaths to the same artifact. Because we need a single artifact "github.sha", we have to use actions/merge to create it. Alternatively craft could be modified but this is the easiest way forward and I like the idea of a unified artifact, it makes craft simpler.

ref: getsentry/craft#552

@joshuarli
Copy link
Member Author

as expected the final release artifact contains the 4 wheels and sdist:

$ unzip -l f3413bd18812984ca0dcf94adcf8b891ce1599c2.zip                                                                0
Archive:  f3413bd18812984ca0dcf94adcf8b891ce1599c2.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
  1041231  09-23-2024 23:55   sentry_ophio-1.0.0-cp310-abi3-macosx_10_12_x86_64.whl
   991355  09-23-2024 23:55   sentry_ophio-1.0.0-cp310-abi3-macosx_11_0_arm64.whl
  4238356  09-23-2024 23:55   sentry_ophio-1.0.0-cp310-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
  4331018  09-23-2024 23:55   sentry_ophio-1.0.0-cp310-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
    26486  09-23-2024 23:55   sentry_ophio-1.0.0.tar.gz
---------                     -------
 10628446                     5 files

Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock! Thanks for streamlining the upload of the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants