Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update actions/upload-artifact to v4 with merge #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshuarli
Copy link
Member

@joshuarli joshuarli commented Sep 23, 2024

Uses artifacts/merge to merge together multiple artifacts from different jobs into the single one named github.sha that craft expects.

Summarily, upload-artifact v3 is deprecated but v4 doesn't support mutating an artifact with the name name by uploading different filepaths to the same artifact. Because we need a single artifact "github.sha", we have to use actions/merge to create it. Alternatively craft could be modified but this is the easiest way forward and I like the idea of a unified artifact, it makes craft simpler.

ref: getsentry/craft#552

This has already been done for numerous other repos.

@joshuarli
Copy link
Member Author

joshuarli commented Sep 23, 2024

the release artifact built here is actually an improvement since it contains both wheels (current github releases only has sentry_jsonnet wheel):

josh@CTKP7QRX4L.local ~/Downloads  $ unzip -l b6282787f1ecde332724553d90b2d1f132f33f83.zip                                                                0
Archive:  b6282787f1ecde332724553d90b2d1f132f33f83.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
     3521  09-23-2024 17:45   sentry_jsonish-0.0.2-py3-none-any.whl
     3054  09-23-2024 17:45   sentry_jsonnet-0.0.4-py3-none-any.whl
---------                     -------
     6575                     2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant