Skip to content

Commit

Permalink
todo
Browse files Browse the repository at this point in the history
  • Loading branch information
bukzor committed Nov 9, 2023
1 parent 825bf02 commit e4cd96e
Showing 1 changed file with 78 additions and 33 deletions.
111 changes: 78 additions & 33 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -1,38 +1,83 @@
# TODO

* [ ] goal: allow sentaurs to use jsonnet in a fully-tested manner
* [ ] submit ops/jsonnet integration:
https://github.com/getsentry/ops/pull/7245/files
* [ ] test getsentry deployment
https://github.com/getsentry/getsentry/blob/master/gocd/templates/backend.jsonnet
* [ ] rework tests of application to gocd
https://github.com/getsentry/gocd-jsonnet
* [ ] DRY pyproject.toml, in this repo
* [ ] we're creating three new python libraries
* [ ] sentry-jsonish -- mostly just typing
* [x] pypi packaging exists
* [x] unit testing
* [ ] readme
* [ ] sentry-jsonnet
* [x] pypi packaging exists
* [ ] update to gojsonnet
* [ ] blocked by: figure out why our pypi GHA has no `go`
* [ ] depends on sentry-jsonish
* [ ] readme
* [ ] test harness: jsonnet-tester
* [ ] refactor pytest to a library
* [ ] extract three functions from jsonnet-private-libs make_port_test.py
* [ ] some unit testing of those three functions
* [ ] later: use those three functions in a pytest extension
* [ ] readme
* [ ] depends on sentry-jsonnet
* sentry-jsonnet-lib
* [ ] add it to this repo
* [ ] repo scope:
* [ ] set up autoreleasing
* [ ] GHA "release" action -- prepares assets and creates an issue in github.com/getsentry/publish
* [ ] blocked by: add all three packages to this repo
* [ ] delete the old getsentry/private-jsonnet-libs
I think we have these. to do:

- [ ] fix the tests in CI. Specifically sentry_jsonnet tests cannot find
sentry_jsonish. It was not a separate lib. We did not publish successfully
a version of the package yet though for sentry_jsonnet to import from
pypi. Other way is to make sentry_jsonnet tests rely on the local
unpublished sentry_jsonish.

- [ ] The test harness. Basically that is a third package to build from the
ground up

- [ ] Fix the CHANGELOG issue. -- Initial `craft prepare` changelog fails
end-of-file fixer precommit.

- [ ] check if that is the expected behavior in craft, may actually be a bug,
craft should be able to create the first commit to a CHANGELOG file with
a proper new line at the end.
- [ ] Otherwise we can just turn the check off for the first release and
re-enable afterwards.
- [ ] Once that is fixed hopefully there are no more blockers to publish the
two libraries.

- [ ] The go-jsonnet issue

- blocked by: a working sentry-pypi release process
- "the go-jsonnet issue" being getsentry/pypi seemingly lacked a go compiler?
- Yeah, the error was something like Command not found: go

- [ ] a working sentry-pypi release process
- blocked by: the CHANGELOG issue

Fixing types. pyright was complaining when I ran it two weeks ago and it is
disabled in pre-commit. Cannot remember which errors we had and whether it was a
config issues or there were actually broken types.

Maybe reuse the release and build GH workflows instead of copy pasting them.
Just as you did for CI.

This is what I know on top of my head now, you may have others as well. So
basically I think you can pick whatever you want there. I'll start working on
this around my 2 pm. I can pick what you did not pick.

---

- [ ] goal: allow sentaurs to use jsonnet in a fully-tested manner
- [ ] submit ops/jsonnet integration:
https://github.com/getsentry/ops/pull/7245/files
- [ ] test getsentry deployment
https://github.com/getsentry/getsentry/blob/master/gocd/templates/backend.jsonnet
- [ ] rework tests of application to gocd
https://github.com/getsentry/gocd-jsonnet
- [ ] DRY pyproject.toml, in this repo
- [ ] we're creating three new python libraries
- [ ] sentry-jsonish -- mostly just typing
- [x] pypi packaging exists
- [x] unit testing
- [ ] readme
- [ ] sentry-jsonnet
- [x] pypi packaging exists
- [ ] update to gojsonnet
- [ ] blocked by: figure out why our pypi GHA has no `go`
- [ ] depends on sentry-jsonish
- [ ] readme
- [ ] test harness: jsonnet-tester
- [ ] refactor pytest to a library
- [ ] extract three functions from jsonnet-private-libs make_port_test.py
- [ ] some unit testing of those three functions
- [ ] later: use those three functions in a pytest extension
- [ ] readme
- [ ] depends on sentry-jsonnet
- sentry-jsonnet-lib
- [ ] add it to this repo
- [ ] repo scope:
- [ ] set up autoreleasing
- [ ] GHA "release" action -- prepares assets and creates an issue in
github.com/getsentry/publish
- [ ] blocked by: add all three packages to this repo
- [ ] delete the old getsentry/private-jsonnet-libs

# out of scope

Expand Down

0 comments on commit e4cd96e

Please sign in to comment.