Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

sdk.name for hybrid sdks #832

Merged
merged 2 commits into from
Feb 9, 2023
Merged

sdk.name for hybrid sdks #832

merged 2 commits into from
Feb 9, 2023

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Feb 9, 2023

This addresses the sdk.name and allows us to find out, for example:

  1. Events from React Native customers
  2. Events from the Cocoa SDK (regardless of hybrid SDK that bundled it)
  3. By looking at an event know exactly what SDK that is: It's cocoa version X but it was part of the Unity SDK

More importantly, this is simple, solves an actual problem we have right now.
And we use this already on Unreal and Unity. Works as intended.

@vercel
Copy link

vercel bot commented Feb 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
develop ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 2:45PM (UTC)

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it simple! This is good

src/docs/sdk/event-payloads/sdk.mdx Outdated Show resolved Hide resolved
src/docs/sdk/event-payloads/sdk.mdx Outdated Show resolved Hide resolved
src/docs/sdk/event-payloads/sdk.mdx Outdated Show resolved Hide resolved
Copy link

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked really well for us so far.

@mattjohnsonpint
Copy link
Contributor

mattjohnsonpint commented Feb 9, 2023

I'm good with this, but have a question:

How far along the stack should this extend? Should we be appending ecosystem.flavor, or just ecosystem?

For example, if calling the Cocoa SDK from various .NET SDKs, appending ecosystem.flavor would result in:

  • sentry.dotnet => sentry.cocoa.dotnet
  • sentry.dotnet.maui => sentry.cocoa.dotnet.maui
  • sentry.dotnet.extensions.logging => sentry.cocoa.dotnet.extensions.logging
  • etc...

Whereas appending only ecosystem would have them all use sentry.cocoa.dotnet.

It would be great if the doc could clarify this point. Thanks.

@mattjohnsonpint
Copy link
Contributor

... but now that I think about it, unity is a flavor, not an ecosystem. Right? So maybe there's no hard rule to follow?

@bruno-garcia
Copy link
Member Author

... but now that I think about it, unity is a flavor, not an ecosystem. Right? So maybe there's no hard rule to follow?

yeah I think this is accurate

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants