Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add createdAt key to json in registry #532

Merged
merged 7 commits into from
Apr 11, 2024
Merged

feat: Add createdAt key to json in registry #532

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e35a36d
feat: Add `created` key to json in registry
HazAT Apr 11, 2024
b18b6cf
ref: createdAt
HazAT Apr 11, 2024
23eec10
ref: Add more type safety
HazAT Apr 11, 2024
01ba9d1
ref changelog
HazAT Apr 11, 2024
12905f5
reset changelog
HazAT Apr 11, 2024
c06bd75
Add simple unit test
HazAT Apr 11, 2024
46f0788
Add mock
HazAT Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.18.0

- feat: Registry target now adds key `createdAt` with current timestamp to json file

HazAT marked this conversation as resolved.
Show resolved Hide resolved
## 1.17.2

- No documented changes.
Expand Down Expand Up @@ -108,7 +112,7 @@

### Various fixes & improvements

- ref: Pin cocoapods version (#496) by @brustolin
- ref: Pin cocoapods version (#496) by @brustolin
HazAT marked this conversation as resolved.
Show resolved Hide resolved

## 1.6.0

Expand All @@ -124,14 +128,14 @@
- build(deps): bump semver from 6.3.0 to 6.3.1 (#470) by @dependabot
- build(deps): bump @babel/traverse from 7.22.5 to 7.23.2 (#494) by @dependabot
- ref: remove volta from CI (#493) by @asottile-sentry
- fix: Handle `{major}.json` and `{minor}.json` symlinks when publishing older versions (#483) by @cleptric
- fix: Handle `{major}.json` and `{minor}.json` symlinks when publishing older versions (#483) by @cleptric
- Bump symbol collector 1.12.0 (#491) by @bruno-garcia

## 1.4.4

### Various fixes & improvements

- fix(brew): Replace version in artifact names with '__VERSION__' to access checksums from mustache (#488) by @romtsn
- fix(brew): Replace version in artifact names with '**VERSION**' to access checksums from mustache (#488) by @romtsn

## 1.4.3

Expand Down
10 changes: 9 additions & 1 deletion src/targets/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,15 @@ export class RegistryTarget extends BaseTarget {
);
}
// Update the manifest
const updatedManifest = { ...packageManifest, version };
const updatedManifest: {
version: string;
createdAt: string;
[key: string]: any;
} = {
...packageManifest,
version,
createdAt: new Date().toISOString(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a plan to backfill this data?

any test that needs updating?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a simple unit test to check if property is there
here is the PR to backfill the data for existing files
getsentry/sentry-release-registry#148

};

// Add file links if it's a generic app (legacy)
if (registryConfig.type === RegistryPackageType.APP) {
Expand Down
Loading