Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Bump Dockerfile base image to node:20-bookworm #472

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jul 12, 2023

needed this because elixir version on bullseye was too old.

version diff

ran the following inside container on both master and this branch

node --version
npm --version
dirmngr --version
ruby --version
gem --version
twine --version
java --version
mvn --version
iex --version
hex --version
dotnet --version
docker --version
cargo --version
gem info cocoapods
dart --version
flutter --version
➜  bump_craft_dockerfile diff -u old new
--- old	2023-07-12 17:06:57
+++ new	2023-07-12 17:18:55
@@ -1,24 +1,25 @@
-v14.21.3
-6.14.18
-dirmngr (GnuPG) 2.2.27
-Copyright (C) 2021 Free Software Foundation, Inc.
+v20.4.0
+9.7.2
+dirmngr (GnuPG) 2.2.40
+Copyright (C) 2022 g10 Code GmbH
 License GNU GPL-3.0-or-later <https://gnu.org/licenses/gpl.html>
 This is free software: you are free to change and redistribute it.
 There is NO WARRANTY, to the extent permitted by law.
-ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux-gnu]
-3.2.5
-twine version 3.3.0 (pkginfo: 1.4.2, requests: 2.25.1, setuptools: 52.0.0, requests-toolbelt: 0.9.1, tqdm: 4.57.0)
-openjdk 11.0.18 2023-01-17
-OpenJDK Runtime Environment (build 11.0.18+10-post-Debian-1deb11u1)
-OpenJDK 64-Bit Server VM (build 11.0.18+10-post-Debian-1deb11u1, mixed mode, sharing)
-Apache Maven 3.6.3
+ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux-gnu]
+3.3.15
+twine version 4.0.2 (importlib-metadata: 4.12.0, keyring: 23.9.3, pkginfo: 1.8.2, requests: 2.28.1, requests-
+toolbelt: 0.10.1, urllib3: 1.26.12)
+openjdk 17.0.7 2023-04-18
+OpenJDK Runtime Environment (build 17.0.7+7-Debian-1deb12u1)
+OpenJDK 64-Bit Server VM (build 17.0.7+7-Debian-1deb12u1, mixed mode, sharing)
+Apache Maven 3.8.7
 Maven home: /usr/share/maven
-Java version: 11.0.18, vendor: Debian, runtime: /usr/lib/jvm/java-11-openjdk-amd64
+Java version: 17.0.7, vendor: Debian, runtime: /usr/lib/jvm/java-17-openjdk-amd64
 Default locale: en_US, platform encoding: ANSI_X3.4-1968
 OS name: "linux", version: "5.15.49-linuxkit-pr", arch: "amd64", family: "unix"
-Erlang/OTP 23 [erts-11.1.8] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1]
+Erlang/OTP 25 [erts-13.1.5] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [jit:ns]

-IEx 1.10.3 (compiled with Erlang/OTP 22)
+IEx 1.14.0 (compiled with Erlang/OTP 24)
 bash: hex: command not found
 7.0.306
 Docker version 24.0.4, build 3713ee1
@@ -30,7 +31,7 @@
     Authors: Eloy Duran, Fabio Pelosin, Kyle Fuller, Samuel Giddins
     Homepage: https://github.com/CocoaPods/CocoaPods
     License: MIT
-    Installed at: /var/lib/gems/2.7.0
+    Installed at: /var/lib/gems/3.1.0

     The Cocoa library package manager.
 Dart SDK version: 3.0.0 (stable) (Thu May 4 01:11:00 2023 -0700) on "linux_x64"

Dockerfile Outdated Show resolved Hide resolved
@sl0thentr0py
Copy link
Member Author

ok well the cloudbuild fails with kaniko, but not with docker locally
https://console.cloud.google.com/cloud-build/builds/db82d56e-57cb-42b3-a4d9-87295bf73d5f;step=2?project=sentryio

INFO[0205] Pushing layer us.gcr.io/sentryio/craft/cache:5118ce18bbb6975b504a52e3bb9abc4549a99f88db2977b5ebfaba3d3801f7a3 to cache now 
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x27020 pc=0x27020]

runtime stack:
runtime.throw(0x7e0c4a, 0x2a)
	/usr/local/go/src/runtime/panic.go:1116 +0x72
runtime.sigpanic()
	/usr/local/go/src/runtime/signal_unix.go:726 +0x4ac

there's stuff like this around
GoogleContainerTools/kaniko#756

@sl0thentr0py
Copy link
Member Author

bumped kaniko to latest and it worked

@sl0thentr0py sl0thentr0py self-assigned this Jul 13, 2023
@sl0thentr0py sl0thentr0py changed the title feat(build): Bump Dockerfile base image to node:20-bookwork feat(build): Bump Dockerfile base image to node:20-bookworm Jul 13, 2023
@sl0thentr0py sl0thentr0py merged commit 0941c46 into master Jul 17, 2023
9 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/bump-debian branch July 17, 2023 13:04
mydea pushed a commit that referenced this pull request Jul 18, 2023
mydea added a commit that referenced this pull request Jul 18, 2023
* Revert "ref: add python3-packaging explicitly (#474)"

This reverts commit ddd80e5.

* Revert "fix(hex): Add erlang-dev for missing parsetools (#473)"

This reverts commit edf83d2.

* Revert "feat(build): Bump Dockerfile base image to node:20-bookworm (#472)"

This reverts commit 0941c46.

---------

Co-authored-by: anthony sottile <103459774+asottile-sentry@users.noreply.github.com>
Co-authored-by: Neel Shah <neel.shah@sentry.io>
@asottile-sentry asottile-sentry mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants