fix(crates): Skip path-only dev-dependencies in dep cycle checking #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See getsentry/sentry-rust#374 (comment)
The initial problem is that cargo validates (dev)-dependencies before publishing, and rejects that if the required version does not exist on crates.io yet. path-only dev-dependencies skip this check, and are thus not holding up publishing.
The previous method of using
cargo-hackand thenoDevDepsflag should be discouraged as it uses the--allow-dirtyflag and thus prevents cargo from putting in more metadata that could be used for crate integrity validation (aka, the code in the crate matches a git commit; which it currently does not due to usage ofcargo-hack)Read https://codeandbitters.com/published-crate-analysis/ for more insight into why
cargo-hackshould be avoided.