ref(reduce): Refactor for timeout=0 #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly simplify the logic so that timeout=0 is honored. Needed for getsentry/team-sns#4
|
Just to make sure I understand correctly what is happening: you're moving the check for whether the deadline has elapsed to the very beginning of the loop so that, in particular for timeout 0, you break immediately before doing anything? |
|
yes exactly, and I also wanted to ensure that I don't call |
loewenheim
approved these changes
May 15, 2024
anonrig
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly simplify the logic so that timeout=0 is honored.
Needed for https://github.com/getsentry/team-sns/issues/4