feat: Increase backpressure threshold to 5 seconds #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During inc-626 we saw excessive backpressure which caused the consumer to be paused and resumed a lot. This led to excessive network traffic as the local queue was purged and messages were re-downloaded. Increase the threshold for pausing to reduce the impact of this.
lynnagara
commented
Feb 23, 2024
tests/processing/test_processor.py
Outdated
| @@ -86,7 +86,7 @@ def test_stream_processor_lifecycle() -> None: | |||
| with assert_changes(lambda: int(consumer.pause.call_count), 0, 1): | |||
| processor._run_once() | |||
| assert strategy.submit.call_args_list[-1] == mock.call(message) | |||
| time.sleep(1) | |||
| time.sleep(5) | |||
There was a problem hiding this comment.
please mock time.time instead
untitaker
approved these changes
Feb 23, 2024
tests/processing/test_processor.py
Outdated
| @@ -86,7 +86,7 @@ def test_stream_processor_lifecycle() -> None: | |||
| with assert_changes(lambda: int(consumer.pause.call_count), 0, 1): | |||
| processor._run_once() | |||
| assert strategy.submit.call_args_list[-1] == mock.call(message) | |||
| time.sleep(1) | |||
| time.sleep(5) | |||
There was a problem hiding this comment.
please mock time.time instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During inc-626 we saw excessive backpressure which caused the consumer to be paused and resumed a lot. This led to excessive network traffic as the local queue was purged and messages were re-downloaded. Increase the threshold for pausing to reduce the impact of this.