Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert change when consumer is paused #297

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

lynnagara
Copy link
Member

This reverts part of the change made in #296, which removed the check for the carried over message, when validating that the consumer is paused. This change was inadvertently introduced and is not actually needed to achieve th goal of throttling calls to consumer pause/resume.

This caused the consumer to crash with InvalidStateError so let's revert this part.

This reverts part of the change made in #296,
which removed the check for the carried over message, when validating that
the consumer is paused. This change was inadvertently introduced and is not actually
needed to achieve th goal of throttling calls to consumer pause/resume.

This caused the consumer to crash with InvalidStateError so let's revert this part.
@lynnagara lynnagara requested a review from a team as a code owner October 27, 2023 20:42
@lynnagara lynnagara enabled auto-merge (squash) October 27, 2023 21:08
@lynnagara lynnagara merged commit 7ba97b4 into main Oct 30, 2023
8 checks passed
@lynnagara lynnagara deleted the revert-message-carried-over branch October 30, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants