ref: Global metrics registry #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register all metrics in the entire codebase in a Literal, and put the literal in docs. This is a bit less overhead than a global enum and requires fewer changes in strategies that already pass metrics as strings.
untitaker
commented
May 25, 2023
| @@ -16,7 +16,12 @@ Nevertheless, all arroyo strategies are written against the following interface: | |||
| :undoc-members: | |||
| :show-inheritance: | |||
|
|
|||
| Messages | |||
There was a problem hiding this comment.
this change is unrelated but imo should land too. I was revisiting how we render typehints, and noticed that Message is undocumented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register all metrics in the entire codebase in a Literal, and put
the literal in docs.
This is a bit less overhead than a global enum and requires fewer
changes in strategies that already pass metrics as strings.