Multi-arch docker image #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scefali, @armenzg Can you please help pushing this change to enable ARM64 support? |
bbednarek
reviewed
Jun 27, 2024
Co-authored-by: Bartosz Bednarek <895578+bbednarek@users.noreply.github.com>
armenzg
approved these changes
Jul 2, 2024
| @@ -16,48 +17,59 @@ jobs: | |||
| docker-build: | |||
| name: Build & pubish Docker images | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| packages: write | |||
There was a problem hiding this comment.
Upload and publish packages to GitHub Packages
👍🏻
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 |
There was a problem hiding this comment.
As reference: https://github.com/marketplace/actions/docker-setup-qemu
| uses: docker/setup-qemu-action@v3 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 |
There was a problem hiding this comment.
| docker push ghcr.io/getsentry/action-release-builder-image:latest | ||
| docker push ghcr.io/getsentry/action-release-image:latest | ||
| - name: Build and push | ||
| uses: docker/build-push-action@v6 |
There was a problem hiding this comment.
| - name: Build and push | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| platforms: linux/amd64,linux/arm64 |
There was a problem hiding this comment.
Before this PR we were only building linux/amd64 but after this PR we will also build linux/arm64
| uses: docker/build-push-action@v6 | ||
| with: | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: ${{ github.ref == 'refs/heads/master' }} |
There was a problem hiding this comment.
For anyone reading this PR afterwards, we will only push the image when the check runs under the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #81