Fix persisting datasource selection choice #6181
Conversation
Closes #5646. We were already storing this in localStorage, however we weren't accounting for the fact that it was stored as a string, rather than an integer.
|
LGTM though I'm not a JS expert. Should we merge in the restyled changes? |
|
Yep, we should merge in the restyled change. 😄 |
Co-authored-by: Restyled.io <commits@restyled.io>
|
Just pressed the button on that restyled change, so lets see how it all goes now. 😄 |
Codecov Report
@@ Coverage Diff @@
## master #6181 +/- ##
=======================================
Coverage 59.71% 59.71%
=======================================
Files 151 151
Lines 12261 12261
Branches 1658 1658
=======================================
Hits 7322 7322
Misses 4733 4733
Partials 206 206 |
|
Interesting. Looks like it's failed the same Cypress test twice. That could be just bad luck on a flaky test, but it might also mean there's something that needs a closer look. Lets run the CI tests a third time, and see what happens... |
Pretty skeptical this PR has any issues, it definitely passed on redashcommunity when I originally filed it. |
|
Flaky test indeed... merging while we can lol |
|
Awesome. 😄 We might need to look into that flaky test if it keeps on causing issues. |
* Fix persisting datasource selection choice Closes getredash#5646. We were already storing this in localStorage, however we weren't accounting for the fact that it was stored as a string, rather than an integer. * Restyled by prettier (getredash#6182) Co-authored-by: Restyled.io <commits@restyled.io> --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Fix persisting datasource selection choice Closes getredash#5646. We were already storing this in localStorage, however we weren't accounting for the fact that it was stored as a string, rather than an integer. * Restyled by prettier (getredash#6182) Co-authored-by: Restyled.io <commits@restyled.io> --------- Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
Closes #5646.
We were already storing this in localStorage, however we weren't accounting for the fact that it was stored as a string, rather than an integer.
What type of PR is this?
Description
We were already storing this in localStorage, however we weren't accounting for the fact that it was stored as a string, rather than an integer.
How is this tested?
Ran redash locally, verified this fixes the issue.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)