New ElasticSearch Query Runner

[susodapop]

What type of PR is this?

• New Query Runner (Data Source)
• Other

Description

This PR incorporates the excellent work from #4391 with adjustments in #5701. I rebased from master and applied both patches to retain everyone's commit attributions.

These changes have been reviewed twice and approved but were never merged. Here's hoping the third time's the charm.

In addition to those commits, I have deprecated the original elasticsearch query runner. Existing connections will continue to exist.

How is this tested?

• Unit tests (pytest, jest)
• E2E Tests (Cypress)
• Manually
• N/A

Unending thanks to @NicolasLM and @wwl717195673 for their unit and manual testing.

I also manually tested the deprecation:

1. Create an elasticsearch data source
2. Apply deprecated=True commit and reload UI3.
3. DS from step 1 is still visible
4. Create elasticsearch2 database
5. Check contents of data_sources table

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Data source selection screen:

[susodapop]

@wwl717195673 Can you please give this a look to make sure my one change looks good? The only change was to remove the dedicated run_query method from XPackSQLElasticSearch since it was identical ElasticSearch2.

[wwl717195673]

@wwl717195673 Can you please give this a look to make sure my one change looks good? The only change was to remove the dedicated run_query method from XPackSQLElasticSearch since it was identical ElasticSearch2.

That's good.Both run_query methods are totally same.You can remove it.

[susodapop]

Thanks! I'm just fixing the logos rendering next and this will be good as gold 👌

[susodapop]

Alright, I have fixed the logos and deprecated elasticsearch. @wwl717195673 can you give this a final look before I merge?

[wwl717195673]

Alright, I have fixed the logos and deprecated elasticsearch. @wwl717195673 can you give this a final look before I merge?

I have reviewed the code.That's awesome!!!

[susodapop]

Thank you everyone for your diligent efforts on this pull request. The new ES query runner has now merged to master 🚀

[JCWahoo]

How do I get the new query runner? I pulled latest and didnt see the UI changes

[susodapop]

Which "latest" did you pull?

[JCWahoo]

The 10.1.0 docker image

…

On Thu, Jul 21, 2022, 5:27 PM Jesse ***@***.***> wrote: Which "latest" did you pull? — Reply to this email directly, view it on GitHub <#5794 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAW7TCVUWP4IIORAGQVPPTVVG6EJANCNFSM53M5KGGA> . You are receiving this because you commented.Message ID: ***@***.***>

[susodapop]

10.1 was released last year so it won't include changes merged since then 😉

If you want the latest preview build that includes this query runner you can use the preview image or you can wait for the V11 release later this summer.

Another way to solve would be to curl the latest query_runner onto your docker host, write your own dockerfile that copies this query runner over the old one (I don't recommend this).

[JCWahoo]

Ah yes, should've opened my eyes on that one :-) Many thanks! Gonna check out the preview release

…

On Thu, Jul 21, 2022 at 6:45 PM Jesse ***@***.***> wrote: 10.1 was released last year so it won't include changes merged since then 😉 If you want the latest preview build that includes this query runner you can use the preview image <https://hub.docker.com/r/redash/redash/tags> or you can wait for the V11 release later this summer. Another way to solve would be to curl the latest query_runner onto your docker host, write your own dockerfile that copies this query runner over the old one (I don't recommend this). — Reply to this email directly, view it on GitHub <#5794 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUAW7TCWUYUB5G5NSGA4KVDVVHHJBANCNFSM53M5KGGA> . You are receiving this because you commented.Message ID: ***@***.***>