Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress touch-ups #5109

Merged
merged 6 commits into from
Aug 19, 2020
Merged

Cypress touch-ups #5109

merged 6 commits into from
Aug 19, 2020

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Aug 16, 2020

What type of PR is this? (check all applicable)

  • Refactor

Description

This PR includes several Cypress touch ups:

  1. Support for non-sequential data source IDs (following Custom primary/foreign key types #5008)
  2. Use Cypress commands to manipulate Redash state instead of functions in the redash-api module.
  3. Support custom baseUrls specified in cypress.json (as well as the possibility to mount Redash)

Related Tickets & Documents

#5008

@rauchy rauchy requested a review from gabrieldutra August 16, 2020 21:17
@restyled-io restyled-io bot mentioned this pull request Aug 16, 2020
Merged
@restyled-io @restyled-commits
Restyled by prettier (#5110)
377cd3b 
Co-authored-by: Restyled.io <commits@restyled.io>
gabrieldutra
gabrieldutra approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@gabrieldutra gabrieldutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rauchy rauchy merged commit de052ff into master Aug 19, 2020
@rauchy rauchy deleted the non-sequential-keys-for-cypress branch August 19, 2020 18:00
andrewdever pushed a commit to andrewdever/redash that referenced this pull request Oct 5, 2020
@restyled-io @restyled-commits @andrewdever
Cypress touch-ups (getredash#5109)
c21a417 
* allow non-sequential IDs for DataSources in Cypress tests

* refactor redash-api to a set of Cypress commands

* support mounting Redash endpoints in Cypress routes

* fix some parameter specs by waiting for schema to load

* extract baseUrl from cypress.json

* Restyled by prettier (getredash#5110)

Co-authored-by: Restyled.io <commits@restyled.io>

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldutra gabrieldutra gabrieldutra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauchy @gabrieldutra