Upgrade Ant Design to v4 #5068
Merged
Upgrade Ant Design to v4 #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client/app/components/ApplicationArea/ApplicationLayout/DesktopNavbar.jsx
Outdated
Show resolved
Hide resolved
gabrieldutra
commented
Aug 12, 2020
| @@ -58,6 +62,5 @@ | |||
| } | |||
|
|
|||
| .databricks-schema-browser-db-dropdown { | |||
| width: auto !important; | |||
| max-width: 50vw; | |||
| width: 50vw !important; | |||
There was a problem hiding this comment.
Since we have windowing now, the auto width doesn't work with it. Also the prop dropdownMatchSelectWidth automatically disables the windowing.
| @@ -141,7 +141,7 @@ export default class ItemsTable extends React.Component { | |||
|
|
|||
| return extend(omit(column, ["field", "orderByField", "render"]), { | |||
| key: "column" + index, | |||
| dataIndex: "item[" + JSON.stringify(column.field) + "]", | |||
| dataIndex: ["item", column.field], | |||
|
I still want to check it on preview before approving, but ATM I have no other comments to the code - stunning work @gabrieldutra! |
kravets-levko
approved these changes
Aug 18, 2020
|
Let's do it 🚀 I rechecked Percy, fixed some minor margin issues, we may see more of those (hopefully nothing critical), but we can fix as it goes. |
gabrieldutra
added a commit
that referenced
this pull request
Aug 30, 2020
This reverts commit a31196a.
2 tasks
andrewdever
pushed a commit
to andrewdever/redash
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This
hugePR updates our Ant Design version to v4, mostly following the migration doc.Although it looks big, the changes in code are not that much. There are a lot of small changes, so I tried to comment on the highlights I see. Also it should be important to keep track of the changes for any code that extends Redash.
Biggest changes from the Ant Migration in Redash
What was done
Iconsuffix to Icon elementsForm.createusage)Related Tickets & Documents
#4908 (not fixed yet, need to remove
dropdownMatchSelectWidthprop)Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Overall the app should remain the same, but there are a few changes that either came from Ant Design default or they was just of easier implementation.
Table Visualization
Header Height
Search Position
(Was simpler to implement this way)
Databricks Schema Browser
Options width
(Since we have windowing now, it was not possible to keep it flexible with items width. I default it to
50vwof width to make sure long names are displayed)(I'll add more relevant visual differences as I notice them)
For more visual differences check Percy Diff
Links for testing
Current master
Antd v4 Redash