Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move page size select to the Paginator component #5064

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Other

Description

Update the Page size select to use Antd api, thus, moving it to be side-to-side with the page selector.

Related Tickets & Documents

Closes #3386

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

pagination-update

@gabrieldutra gabrieldutra self-assigned this Jul 24, 2020
@arikfr arikfr requested a review from kravets-levko July 27, 2020 13:32
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@jezdez
Copy link
Member

jezdez commented Jul 27, 2020

Nice!

@gabrieldutra gabrieldutra merged commit f3a47a9 into master Jul 27, 2020
andrewdever pushed a commit to andrewdever/redash that referenced this pull request Oct 5, 2020
@guidopetri guidopetri deleted the move-page-size-select branch July 22, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Pages: use Pagination's built in support for showing page size options
3 participants