Load extensions on db init #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
approved these changes
Jul 23, 2020
jezdez
reviewed
Jul 23, 2020
| def load_extensions(db): | ||
| with db.engine.connect() as connection: | ||
| for extension in settings.dynamic_settings.database_extensions: | ||
| connection.execute(f'CREATE EXTENSION IF NOT EXISTS "{extension}";') |
andrewdever
pushed a commit
to andrewdever/redash
that referenced
this pull request
Oct 5, 2020
* Only try to create tables and stamp DB if not tables exist already. * load extensions when creating the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Following #5008, it might be best to allow any custom database extensions to load before creating the database. This PR allows specifying these extensions using the dynamic settings module.
Also, it will only try to create tables and stamp the DB if the tables exist already.
Related Tickets & Documents
#5008
Mobile & Desktop Screenshots/Recordings (if there are UI changes)