Update Ace Editor version #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like a reasonable solution. |
Yep, I left the full "tablename.columnname" for now. |
arikfr
approved these changes
Jul 14, 2020
From a quick check, seems fine for Chrome, firefox and Safari. I'll merge so we can test it more on the Preview env. |
andrewdever
pushed a commit
to andrewdever/redash
that referenced
this pull request
Oct 5, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Updating Ace Editor seemed as simple as that, only thing that needs to be yet solved is that ajaxorg/ace#3676 was a breaking change to #3092 😕. We displayed column names only instead of "table.column" when the dot was pressed.
Options:
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--