Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization Embed: Add option to hide timestamp #4491

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Dec 25, 2019

What type of PR is this?

  • Feature

<span className="small visible-print">
<i className="zmdi zmdi-time-restore" /> {formatDateTime(updatedAt)}
{!hideTimestamp && (
<span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note: currently this <span> is what moves the buttons to the right side, if you don't want them to be in the left side when there's no timestamp, just keep it empty 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, but that's inline with the current implementation on SaaS, so safe to keep :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants