Remove --max-old-space-size=4096 from npm build command

[arikfr]

What type of PR is this? (check all applicable)

• Other

Description

Looks like it's no longer needed.

Related: #4195.

[kravets-levko]

Seems it does not work: build failed with out of memory error in node

[arikfr]

Seems it does not work: build failed with out of memory error in node

Strange it worked locally after the unused dependencies removal. Will verify again.

[kravets-levko]

Map visualization test is flaky, but I'll look into it a bit later. Except of this - looks fine 👍

[arikfr]

Looks like it's also Node version dependent. I wonder if changing this now will break existing environments for people? :-\

I did stumble at Volta recently, which makes it easy to run the correct Node version per project so maybe it's not a huge deal.

@kravets-levko @gabrieldutra @rauchy what Node version you have locally?

[rauchy]

Locally I'm on v11.9, but I don't do local nowadays :) so it's v8.10

[arikfr]

@rauchy

Locally I'm on v11.9, but I don't do local nowadays :) so it's v8.10

v8.10 😱 Just use Volta. Takes a minute and you have whatever version you want.

[kravets-levko]

what Node version you have locally?

v10.13.0

[gabrieldutra]

what Node version you have locally?

v12.13.0, I updated a few days ago 🙂

[rauchy]

Just use Volta. Takes a minute and you have whatever version you want.

It really did!

[arikfr]

I added another npm run command build:old-node-version, which has the old max memory setting for those who use an older Node version.