Allow undefined max_age parameter in query_results endpoint

[stanhu]

An Error 500 would be returned by the endpoint if you attempt to
pass a query parameter to the dashboard since maxAge is undefined in the JavaScript code. This line of code was being executed:

https://github.com/EverythingMe/redash/blob/74a5121be232a0a6002928c38c7290298370c7e0/rd_ui/app/scripts/services/resources.js#L454

[arikfr]

Why can't we keep using request.json?

[stanhu]

I tried to keep it, but the test case seems to serialize it into a format that can't be parsed by request.json:

https://github.com/EverythingMe/redash/blob/master/tests/test_controllers.py#L33

Is it missing a header of some sort? I didn't have time to research. I just changed it to be consistent with the rest of the code in the controllers.

[arikfr]

Got it. I think there is a way to tell Flask to return json regardless of
the content type header. But keep it as is, I'll fix the test helper and
update it later.
On May 15, 2015 7:42 AM, "stanhu" notifications@github.com wrote:

In redash/controllers.py
#432 (comment):

@@ -450,7 +450,7 @@ def delete(self, visualization_id):
class QueryResultListAPI(BaseResource):
@require_permission('execute_query')
def post(self):

•    params = request.json
  

I tried to keep it, but the test case seems to serialize it into a format
that can't be parsed by request.json:

https://github.com/EverythingMe/redash/blob/master/tests/test_controllers.py#L33

Is it missing a header of some sort? I didn't have time to research. I
just changed it to be consistent with the rest of the code in the
controllers.

—
Reply to this email directly or view it on GitHub
https://github.com/EverythingMe/redash/pull/432/files#r30384750.

[stanhu]

Looks like I'm right:

http://stackoverflow.com/questions/20001229/how-to-get-posted-json-in-flask

I can fix this now if you'd like.

[stanhu]

Updated! Using get_json(force=True) is not much shorter than json.loads(request.data). :)

[arikfr]

:-) true that.

I wonder if once I get to fix the test helper, we should keep the get_json(force=True) (it's used in other places too, I think) or not ...

[arikfr]

Thanks!