Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maildev to the dev stack #4173

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Add maildev to the dev stack #4173

merged 2 commits into from
Sep 25, 2019

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Sep 23, 2019

What type of PR is this? (check all applicable)

  • Feature

Description

Maildev adds a simple interface for receiving e-mail in dev mode. This PR adds maildev to the development Docker stack and configures the app to use it. E-mails can be found at http://localhost:1080.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

redash/settings/__init__.py Outdated Show resolved Hide resolved
Co-Authored-By: Arik Fraimovich <arik@arikfr.com>
@arikfr arikfr merged commit 2c77c21 into master Sep 25, 2019
@arikfr arikfr deleted the maildev branch September 25, 2019 07:50
@arikfr
Copy link
Member

arikfr commented Sep 25, 2019

👍

@ranbena
Copy link
Contributor

ranbena commented Sep 25, 2019

What's the Redash mail config to enable this?

@rauchy
Copy link
Contributor Author

rauchy commented Sep 25, 2019

@ranbena this is enabled by default when running the dev docker-compose stack. Just open http://localhost:1080

@ranbena
Copy link
Contributor

ranbena commented Sep 25, 2019

@rauchy I mean the Mail config env vars. I assume at least REDASH_MAIL_DEFAULT_SENDER is needed.

@ranbena
Copy link
Contributor

ranbena commented Sep 25, 2019

Oh it's there already 10x!

@arikfr
Copy link
Member

arikfr commented Sep 25, 2019

@ranbena after getting the updated Compose file, you will need to run docker-compose up -d (or just docker-compose up if that's what you usually do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants