Feature: sort by Y values charts that have a single value per series #410
Conversation
stanhu
force-pushed
the
sort-by-y-values
branch
from
54ca8b6 to
fd056ed
Compare
| @@ -325,6 +325,36 @@ | |||
| series = seriesCopy; | |||
| } | |||
|
|
|||
| if (chartOptions['sortY'] === true || chartOptions['sortY'] === undefined) { | |||
There was a problem hiding this comment.
chartOptions['sortY'] === undefined means that "old" queries without this setting will default to enabling this, right? I prefer that we don't do this, to avoid confusion and unexpected results for existing charts/users.
There was a problem hiding this comment.
Right, that makes sense.
|
Btw, until this merged, if you uncheck the "Sort X values" option of the chart, it will preserve the order the results returned from the database, so you can already sort by y value if you change the query. See this as an example: Just play with the "Sort X values" option. |
|
Right, the sort by X functionality doesn't do what we need here. As mentioned above, we have a table that looks like:
|
arikfr
changed the title
Feature: sort by Y values charts that have a single value per series
We have a lot of bar charts that should be sorted by y values. This pull request adds a "sortY" option.