Counter visualization: formatting not applied to target value #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@susodapop You're welcome to test the fix as well 🙇♂️ |
|
|
ranbena
reviewed
Aug 2, 2019
| @@ -1,5 +1,5 @@ | |||
| import numberFormat from 'underscore.string/numberFormat'; | |||
Damn @susodapop you don't got Roboto on your system. Until we fix it, can you install it on your OS (for the vids)? |
|
@ranbena You are way better at spotting fonts than I am! I downloaded Roboto to my system. Previous to that the counter was rendered in San Francisco.
|
1 task
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
This was referenced Apr 28, 2020
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Refactor:
underscore.string/numberFormatwithnumeraland removedunderscore.stringdependency - it was the only file that used it;numberfilter withnumeral(for consistency and to simplify future React migration); addedtooltipFormatoptions that currently just matchesnumberfilter behavior; added TODO to implement this option in editor.Related Tickets & Documents
Fixes #4031
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before:
After:
