Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut for format query (Ctrl/Cmd+Shift+F) #3911

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Jun 18, 2019

What type of PR is this? (check all applicable)

  • Feature

Description

Ctrl/Cmd + Shift + F will trigger format query. Currently works when you're in the query editor.

Copy link
Contributor

@rauchy rauchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 much needed!

How can users find out about this?

@gabrieldutra
Copy link
Member

I could swear this shortcut already existed 🤔

How can users find out about this?

Yep, perhaps add in the tooltip simular to "Add new parameter".

@cypress
Copy link

cypress bot commented Jun 18, 2019



Test summary

63 0 0 0


Run details

Commit 016a566
Started Jun 18, 2019 10:52 AM UTC
Ended Jun 18, 2019 11:00 AM UTC
Duration 07:48 💡
OS linux Debian - 8.10
Browser Electron 61.0.3163.100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of your project's GitHub integration settings. You can manage this integration in your project's settings in the Cypress Dashboard

@arikfr
Copy link
Member Author

arikfr commented Jun 18, 2019

Yep, perhaps add in the tooltip simular to "Add new parameter".

I forgot about this 🤦‍♂

Thanks, @ranbena for taking care of this :)

@arikfr arikfr merged commit 27c64b4 into master Jun 18, 2019
@arikfr arikfr deleted the format-kb-shortcut branch June 18, 2019 11:10
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
…3911)

* Add keyboard shortcut for format query

* Added to button tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants