Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard grid markings #3656

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Dashboard grid markings #3656

merged 3 commits into from
Apr 29, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Mar 29, 2019 •
edited
Loading

What type of PR is this?

  • Feature

Description

Added grid tile markings to dashboard edit mode.
Discussion in https://discuss.redash.io/t/dashboard-grid-markings/3515.

  • Auto adjusts to fit 6 cols in viewport width
  • Turns off when in 1 column mode

Reviewer 👋

  1. Commit 1 - Added the grid bg.
  2. Commit 2 - Made the grid container go all the way to the bottom (or else it would be only as high as the widgets 👎)

Mobile & Desktop Screenshots

Screen Shot 2019-04-10 at 14 26 33

@ranbena
Copy link
Contributor Author

ranbena commented Apr 7, 2019

Abandoning https://discuss.redash.io/t/dashboard-grid-markings/3515/7

@ranbena ranbena closed this Apr 7, 2019
@ranbena
Copy link
Contributor Author

ranbena commented Apr 9, 2019

Reopening due to https://discuss.redash.io/t/dashboard-grid-markings/3515/8?u=ranbena

@ranbena ranbena reopened this Apr 9, 2019
@arikfr
Copy link
Member

arikfr commented Apr 9, 2019

An issue I noticed here:
image

X button is always visible.

@arikfr
Copy link
Member

arikfr commented Apr 9, 2019

I'm still mind blown that all of this niceness is implemented mostly with CSS. Looks like magic to me. 🤯

@ranbena ranbena mentioned this pull request Apr 9, 2019
Closed
1 task
@ranbena ranbena marked this pull request as ready for review April 10, 2019 11:31
@ranbena ranbena requested a review from kravets-levko April 10, 2019 11:31
@ranbena ranbena force-pushed the tile branch 2 times, most recently from 63d68a7 to 2918194 Compare April 22, 2019 07:43
kravets-levko
kravets-levko approved these changes Apr 23, 2019
View reviewed changes
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Percy says that there is an extra padding on dashboard page, but seems its not an issue.

@arikfr
Copy link
Member

arikfr commented Apr 29, 2019

Should we merge this now? @ranbena

@ranbena ranbena merged commit 24a5748 into master Apr 29, 2019
@ranbena ranbena deleted the tile branch April 29, 2019 12:49
@ranbena ranbena mentioned this pull request Apr 29, 2019
Merged
1 task
@weekly-digest weekly-digest bot mentioned this pull request May 6, 2019
Closed
@ranbena ranbena mentioned this pull request May 13, 2019
Merged
10 tasks
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@ranbena @harveyrendell
Dashboard grid markings (getredash#3656)
a4c1ffc
@snyk-bot snyk-bot mentioned this pull request Aug 20, 2021
Open
This was referenced Sep 12, 2021
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request May 14, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 20, 2023
Open
@Ariffirdausazman Ariffirdausazman mentioned this pull request Mar 22, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Mar 23, 2024
Open
@Ariffirdausazman Ariffirdausazman mentioned this pull request May 13, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request May 13, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request May 23, 2024
Open
@Ariffirdausazman Ariffirdausazman mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kravets-levko kravets-levko kravets-levko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranbena @arikfr @kravets-levko