Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notification alignment #3645

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fixed notification alignment #3645

merged 1 commit into from
Mar 28, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Mar 27, 2019

What type of PR is this?

  • Bug Fix

Description

Notification alignment is off - the close button and left spacing.
Also, took the liberty to swap previous ant.less overrides for variable ones.

Font looked a little off but I checked it and it's redash font no doubt, so no change.

Mobile & Desktop Screenshots

Looking betta

Screen Shot 2019-03-27 at 18 08 38

With desc the icon alignment is gross but there's no hooks for that so f**k it

Screen Shot 2019-03-27 at 18 12 33

@ranbena ranbena requested a review from arikfr March 27, 2019 16:28
@arikfr arikfr merged commit 1871287 into master Mar 28, 2019
@arikfr arikfr deleted the notif-style branch March 28, 2019 08:08
@arikfr
Copy link
Member

arikfr commented Mar 28, 2019

💅

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants