Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Results fails to use query which has double quotes in column names #3618

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Query Results fails to use query which has double quotes in column names #3618

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b88c46
Query Results fails to use query which has double quotes in column names
kravets-levko Mar 21, 2019
8dc0d9c
Tests
kravets-levko Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redash/query_runner/query_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def create_tables_from_query_ids(user, connection, query_ids, cached_query_ids=[


def fix_column_name(name):
return u'"{}"'.format(name.replace(':', '_').replace('.', '_').replace(' ', '_'))
return u'"{}"'.format(re.sub('[:."\s]', '_', name, flags=re.UNICODE))


def create_table(connection, table_name, query_results):
Expand Down