Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #307 Fix: Notifications stopped working #356

Merged
merged 2 commits into from
Jan 22, 2015

Conversation

alexanderlz
Copy link
Member

Updated to use the newer Notification object (as described in MDN)

@joeysim
Copy link
Contributor

joeysim commented Jan 21, 2015

Where's the like button?

@@ -27,23 +30,13 @@
return;
}

if (document.webkitVisibilityState && document.webkitVisibilityState == 'visible') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here to make sure we don't show notifications when the page is in focus. Is there a reason you removed it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To emphasize the effect of notifying!
the truth is I removed it while testing to always see the notifications, and decided it's not that bad to keep it that way.
wdyt?

@arikfr arikfr changed the title Bug #307 fix. Notifications stopped working Bug #307 Fix: Notifications stopped working Jan 22, 2015
var notification = window.webkitNotifications.createNotification('', title, content);
lastNotification = notification;
//using the 'tag' to avoid showing duplicate notifications
var notification = new Notification(title, {'tag': title+content, 'body': content});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't you using the title anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using the title.
the title is the first parameter passed to the constructor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

arikfr added a commit that referenced this pull request Jan 22, 2015
Bug #307 Fix: Notifications stopped working
@arikfr arikfr merged commit 83727ae into getredash:master Jan 22, 2015
washort pushed a commit to washort/redash that referenced this pull request Apr 30, 2018
washort pushed a commit to washort/redash that referenced this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants