Bug #307 Fix: Notifications stopped working #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where's the like button? |
| @@ -27,23 +30,13 @@ | |||
| return; | |||
| } | |||
|
|
|||
| if (document.webkitVisibilityState && document.webkitVisibilityState == 'visible') { | |||
There was a problem hiding this comment.
This is here to make sure we don't show notifications when the page is in focus. Is there a reason you removed it?
There was a problem hiding this comment.
To emphasize the effect of notifying!
the truth is I removed it while testing to always see the notifications, and decided it's not that bad to keep it that way.
wdyt?
arikfr
changed the title
| var notification = window.webkitNotifications.createNotification('', title, content); | ||
| lastNotification = notification; | ||
| //using the 'tag' to avoid showing duplicate notifications | ||
| var notification = new Notification(title, {'tag': title+content, 'body': content}); |
There was a problem hiding this comment.
Why aren't you using the title anymore?
There was a problem hiding this comment.
I am using the title.
the title is the first parameter passed to the constructor
arikfr
added a commit
that referenced
this pull request
Jan 22, 2015
Bug #307 Fix: Notifications stopped working
washort
pushed a commit
to washort/redash
that referenced
this pull request
Apr 30, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use the newer Notification object (as described in MDN)