Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UTC display to scheduler dialog #3517
Added UTC display to scheduler dialog #3517
Changes from all commits
6d2130d
4156776
606cd32
0a7376a
047e46c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome 👌
But has one small issue: you assume 2 hours difference between the timezone and UTC. But what happens when DST kicks in (or the other way around)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be solved setting timezone for tests not using name, but explicitly
TZ=GMT-2:00
or somethingredash/package.json
Line 16 in 549f878
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good save @arikfr :)
Now that I think of it, our other test snapshots might also fail when DST changes on March 29th! 😵
But I couldn't figure out an appropriate
TZ
value. Couldn't find docs, seems like it accepts only location strings and UTC. No offset. Plz help.If no solution is found, might need to fallback to
TZ=UTC
and mock offset in test itself.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranbena
![image](https://user-images.githubusercontent.com/12139186/53764499-279c7800-3ed6-11e9-8819-56e31feafb47.png)
TZ
is just a system variable and all programs should respect it:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10x @kravets-levko but it just doesn't work.
I changed to a non-dst timezone instead, so we're good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jest - 🤦♂️