Query params for filters

[barnash]

I made it possible to register filters values in the query string - for dashboard view.
For example:
http://localhost:9001/dashboard/mydashboard?filter1=4&filter2=5

[arikfr]

How about we use filter.name? It has more chances to be more URL friendly (in most cases it's the table column name -> no capital letters and no spaces).

[barnash]

@arikfr Yeah, you are right, I thought that it will just be easy to create the url since the friendly name is right there when you want to create he deep link. Ofc name makes much more sense. Changed.

[arikfr]

Merged. @barnash congrats on your first contribution :-)

[arikfr]

@barnash two things I overlooked:

1. Following this change, dashboard filters are enabled for all dashboards regardless of the feature flag. This is fixed in: 16f0413
2. filter.name is in the format of "filter-name::filter", while I thought it's only "filter-name"... This is no so friendly, so I might change it in the future to make it easier.

[barnash]

Cool, sounds good.

On Tue Jan 20 2015 at 4:42:28 PM Arik Fraimovich notifications@github.com
wrote:

@barnash https://github.com/barnash two things I overlooked:

1. Following this change, dashboard filters are enabled for all dashboards
   regardless of the feature flag. This is fixed in: 16f0413
   16f0413
2. filter.name is in the format of "filter-name::filter", while I thought
   it's only "filter-name"... This is no so friendly, so I might change it in
   the future to make it easier.

—
Reply to this email directly or view it on GitHub
#347 (comment).