-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding .stickler.yml configuration file #3302
Conversation
I'm looking into the option of replacing CodeClimate with Stickler. While I know we all will miss the lovely "Your method has 7 lines (exceeds 6 allowed)", the main benefit of Stickler, that it makes fixes on its own! So no more making a commit just to fix this missing whitespace at the end of the file... 👌 Anyway, let's give it a shot and see if it's better or not. |
Neat! +1 |
redash/__init__.py
Outdated
@@ -60,7 +60,7 @@ def create_redis_connection(): | |||
|
|||
return client | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool 😁
After some additional thought I realized that while the autofix feature is really nice, it has the potential to create confusion for contributors:
At this point, if they aren't familiar with Git enough, they might get confused/frustrated. The value we get from the auto fixes doesn't seem to worth this friction point. 👋 Stickler. I will still put some effort in either replacing CodeClimate with a less noisy tool or adjust its settings. |
@arikfr It would be neat if Stickler would just use the new change suggestions instead of fixing the problems outright. |
@jezdez actually this is what I was looking for initially. But couldn't find such a solution. It's possible that there is no API for this feature yet, because it's still in beta. |
@arikfr Ah I forgot it's in beta, true. I'd be surprised if Stickler wouldn't use it once it's in GA. |
I'm looking into the option of replacing CodeClimate with Stickler. While I know we all will miss the lovely "Your method has 7 lines (exceeds 6 allowed)", the main benefit of Stickler, that it makes fixes on its own! So no more making a commit just to fix this missing whitespace at the end of the file... 👌
Discussion: https://discuss.redash.io/t/replace-codeclimate-with-sticklerci/3037.