Fix: Able to set out-of-range refresh interval #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
arikfr
approved these changes
Jan 3, 2019
ranbena
force-pushed
the
feature/refresh-schedule/styling
branch
2 times, most recently
from
fdf91ae to
18b3ceb
Compare
ranbena
force-pushed
the
fix/out-of-range
branch
from
3b5cc09 to
8458da0
Compare
ranbena
changed the base branch from
feature/refresh-schedule/styling
to
master
This was referenced Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3249
The fix
Before setting
countnow code checks if out of range, and if so sets to "1".Implementation notes
Had to convert getter to simple function in order to send the
newIntervalargument.