Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search by data_source in Search Page #2530

Closed
wants to merge 1 commit into from

Conversation

teradonburi
Copy link

Hello!

We usually use redash for analyze our product and this is great tool.
We create many queries with various types of datasources, but we would like to display the datasources type from hard to find queries by datasources.

Then:
I add follow feature: show datasources name in Search Page

・screenshot here
2018-05-12 23 54 43

Thanks.

@kyoshidajp
Copy link
Member

Cool feature 👍

@kocsmy
Copy link
Collaborator

kocsmy commented May 20, 2018

FYI this separate search queries tab will be discounted here: https://github.com/getredash/redash/commits/discovery

Not sure how to implement this feature there though (I think we shouldn't show the data source by default).

@teradonburi
Copy link
Author

@kocsmy
Thank you for your reply.

Oh... I see.
We need Data Source info to search and reuse exist query.
We suggest to add Data Source info to edit mode of graph or query list.

@teradonburi teradonburi closed this Jun 9, 2018
@arikfr
Copy link
Member

arikfr commented Jun 20, 2018

@teradonburi the branch @kocsmy linked to is this: #2573 pull request. You're welcome to implement this functionality on top of the work we do there. Although I recommend to wait until it's merged, to work on stable code.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants