Add location property to BigQuery data source settings #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoshidajp
force-pushed
the
support_location_in_bq_dataset
branch
from
b86bb16 to
bd1c5fa
Compare
|
Thanks kyoshidajp! |
arikfr
reviewed
Jul 25, 2018
redash/query_runner/big_query.py
Outdated
| @@ -148,10 +155,15 @@ def _get_bigquery_service(self): | |||
| def _get_project_id(self): | |||
| return self.configuration["projectId"] | |||
|
|
|||
| def _get_location(self): | |||
| location = self.configuration.get("location", "") | |||
| return "US" if location == "" else location | |||
There was a problem hiding this comment.
I think you can simplify this into:
def _get_location(self):
return self.configuration.get("location", "US")No?
redash/query_runner/big_query.py
Outdated
| @@ -110,6 +113,10 @@ def configuration_schema(cls): | |||
| "type": "boolean", | |||
| 'title': "Use Standard SQL (Beta)", | |||
| }, | |||
| 'location': { | |||
| "type": "string", | |||
| 'title': 'Processing Location (default: US)', | |||
There was a problem hiding this comment.
For default values we have the default property of the configuration item.
kyoshidajp
force-pushed
the
support_location_in_bq_dataset
branch
from
889aeda to
5ca59a5
Compare
|
@arikfr Thanks. I fixed. Could you review again? |
|
Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
BigQuery began to support Tokyo region from April this year.
This PR adds a location property to BigQuery data source settings. And calls job query with it.
If it is not specified, the value is
US(which is default BigQuery location).Screenshot