[Athena] Fix: missing databases (apply pagination) #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
May 2, 2018
redash/query_runner/athena.py
Outdated
| database_paginator = client.get_paginator('get_databases') | ||
| table_paginator = client.get_paginator('get_tables') | ||
| databases = (database for databases in database_paginator.paginate() | ||
| for database in databases['DatabaseList']) |
There was a problem hiding this comment.
something in these 2 lines doesn't look right. are you sure this is what you wanted?
There was a problem hiding this comment.
We want to paginate over both databases and tables.
A database paginator returns a list of lists, in the l#130 I flatten it inside a generator.
There was a problem hiding this comment.
Maybe it would suffice to just indent the double for-loops differently to make it more clear?
arikfr
reviewed
Jul 31, 2018
redash/query_runner/athena.py
Outdated
| database_paginator = client.get_paginator('get_databases') | ||
| table_paginator = client.get_paginator('get_tables') | ||
| databases = (database for databases in database_paginator.paginate() | ||
| for database in databases['DatabaseList']) |
There was a problem hiding this comment.
Thank you for making the change into two for-loops. But don't we need to remove lines 130-131 now?
ghost
assigned 
arikfr
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2500.