add support ChatWork Alert Destination. #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Jul 29, 2018
redash/destinations/chatwork.py
Outdated
|
|
||
|
|
||
| class ChatWork(BaseDestination): | ||
| ALERTS_DEFAULT_MESSAGE_TEMPLATE = '{alert_name} changed state to {new_state}.\\n{alert_url}\\n{query_url}' |
There was a problem hiding this comment.
Alert names might include unicode so it's better to use a unicode string (i.e. prefix this with u -> u'{alert_name} changed...').
| alert_url = '{host}/alerts/{alert_id}'.format(host=host, alert_id=alert.id) | ||
| query_url = '{host}/queries/{query_id}'.format(host=host, query_id=query.id) | ||
|
|
||
| message_template = options.get('message_template', ChatWork.ALERTS_DEFAULT_MESSAGE_TEMPLATE) |
There was a problem hiding this comment.
It's better that we use some proper templating engine here to avoid possible security risk that can be introduced by using a user input with String#format.
We already use pystache, so you can easily use it.
There was a problem hiding this comment.
I've realized that we do the same thing in email destination... so will address both together.
|
Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://go.chatwork.com/