Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift: add support for the new ACM root CA. #2044

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Redshift: add support for the new ACM root CA. #2044

merged 1 commit into from
Oct 18, 2017

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Oct 18, 2017

Closes #1974.

@arikfr arikfr merged commit bc6bd1b into master Oct 18, 2017
@arikfr arikfr deleted the redshift branch October 18, 2017 12:59
@galgoogle
Copy link

galgoogle commented Oct 18, 2017

@arikfr We've "fixed" it on our side by changing the pg.py file.
We've downloaded the certification file redshift-ca-bundle.crt.
And under /opt/redash/current/redash/query_runner we've edited pg.py:

if "redshift" in self.configuration.get('host'):
                connection = psycopg2.connect(user=self.configuration.get('user'),
                                              password=self.configuration.get('password'),
                                              host=self.configuration.get('host'),
                                              port=self.configuration.get('port'),
                                              dbname=self.configuration.get('dbname'),
                                              sslrootcert='/opt/redash/redshift-ca-bundle.crt',
                                              async=True)

That's because our hostname contains the string "redshift". I'm sure you can do it in a more elegant way.

@arikfr
Copy link
Member Author

arikfr commented Oct 18, 2017

@galgoogle that's pretty much what this pull request does just in a cleaner way :)

dairyo pushed a commit to KiiCorp/redash that referenced this pull request Mar 1, 2019
Redshift: add support for the new ACM root CA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants