Fixed eslint "Cannot read property 'length' of undefined" error #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!
I know that Angular 1.6 had breaking changes that affected our codebase and the other packages might have some too. I don't want this PR to wait for proper QA of all the changes, so how about we keep only the dev dependencies updates for now and move the other upgrades to a future pull request?
Was it done with something like prettier? |
|
@arikfr Reverted angular to previous version. Code style mostly was fixed with |
|
Merged. Thanks 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
eslintissue: eslint/eslint#4259webpack-dev-serverproxy config to rewrite origin (needed to avoid remote server's errors).