Fix: don't show warning when query string (parameters value) changes #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,7 @@ | |||
| } | |||
|
|
|||
| $scope.$on('$locationChangeStart', function (event, next, current) { | |||
| if (next.split("#")[0] == current.split("#")[0]) { | |||
| if (next.split("?")[0] == current.split("?")[0]) { | |||
There was a problem hiding this comment.
We need the previous check (with the #) too, for cases when the user changes the current visualization and there are no parameters present (and hence no query string parameters).
There was a problem hiding this comment.
Thank you for your review. fixed 7843d2e
arikfr
changed the title
hokaccha
force-pushed
the
fix-confirm-dialog
branch
from
c7ae2b8 to
7843d2e
Compare
|
Thanks! |
simo7
pushed a commit
to pubnative/redash
that referenced
this pull request
Sep 22, 2016
Fix: don't show warning when query string (parameters value) changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes #1174