Fix: use the email input type where needed #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ | |||
| <form role="form" method="post" name="login"> | |||
| <div class="form-group"> | |||
| <label for="inputEmail">Email</label> | |||
| <input type="text" class="form-control" id="inputEmail" name="email" value="{{email}}"> | |||
| <input type="email" class="form-control" id="inputEmail" name="email" value="{{email}}"> | |||
There was a problem hiding this comment.
While it makes sense, it's a problem as sometimes "email" is used just as a username -- like the default admin user. Changing type here will prevent people from logging in...
|
Thanks! See my comments. |
|
Updated this pull request. Please review it again. |
arikfr
changed the title
|
Thanks! |
simo7
pushed a commit
to pubnative/redash
that referenced
this pull request
Sep 22, 2016
Fix: use the email input type where needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, use the email input type for a good UX.