Feature: add --org option to all relevant CLI commands. #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--org is the organization slug, not the name. Allows the management of users, datasources and groups with respect to organisations. All commands default to 'default' slug, or None where relevant, which means the commands will still work as they did before without any changes.
| @@ -7,8 +7,7 @@ | |||
| manager = Manager(help="Users management commands. This commands assume single organization operation.") | |||
There was a problem hiding this comment.
You will need to update this :)
Move organization to the end of the parameter list to prevent breaking any existing code. Provide a default for all organization parameters to allow people to call the CLI functions without breaking existing code. Add missing organization parameter to `list` in `users.py`.
Add "(leave blank for 'default')." or "(leave blank for all organizations)" to organization options. Remove the text "This commands assume single organization operation." from the `users` and `groups` managers help text.
|
I've updated that text for both |
arikfr
changed the title
|
Merged. Thanks! I'll be happy to hear on how you're using this. There is no email in your profile, so you're welcome to reach out (arik at redash.io). |
simo7
pushed a commit
to pubnative/redash
that referenced
this pull request
Sep 22, 2016
Feature: add --org option to all relevant CLI commands.
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Feature: add --org option to all relevant CLI commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--org is the organization slug, not the name.
Allows the management of users, datasources and groups
with respect to organisations.
All commands default to 'default' slug, or None where
relevant, which means the commands will still work
as they did before without any changes.