Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the vagrant flow #1043

Closed
wants to merge 37 commits into from
Closed

Improve the vagrant flow #1043

wants to merge 37 commits into from

Conversation

staritza
Copy link
Contributor

@staritza staritza commented May 9, 2016

This pr allows a user to run redash locally or test without having to run any manual steps, except the run command itself. We also updated the docs to include this change.

To run locally, run ./bin/vagrant_ctl.sh start
To test, ./bin/vagrant_ctl.sh test

ChrisKozak and others added 18 commits April 27, 2016 17:22
@ChrisKozak
Chris - Adding test script for the build pipeline
cfdd5eb
@ChrisKozak
Chris - Fixing bash script
a1277a9
@amasare
Ama: Change Docker repo to our docker repo
24d4d72
@amasare
Ama: Pull from redash latest instead of recruitingdev latest
8535adb 
We dont have any images in recruitingdev yet
@amasare
Ama: Add deploy to s3 from circle ci
c8de4a8
@amasare
Ama: Modify circle ci code deploy
a08da6d
@amasare
Ama: Fix indentation for code deploy on circle ci
f36a522
@amasare
Ama: Add deployment_config for circle ci code deploy
e7b7b4d
@amasare
Ama: Add more config options for circle ci code deploy
d4e6448
@amasare
Ama: Remove code deploy config. Delete uneeded docker image deploy
275f824 
The team decided to leave the artifacts in Circle and have another pipeline which will pull the artifacts from Circle into Go.
@amasare
Ama/Kozak: Remove uneccesary docker info
418ebcf
@amasare
Merge tag 'tags/v0.10.0.b1774'
6cc39d6
@amasare
Ama/Kozak: Delete script we created. No longer needed.
3a4050f 
We are using redash's circle script which includes testing
@amasare
Kumar: Make bottom margin on visualizations editable
1f8b9f2
@amasare
Ama/Chris #7121 Added script to run or test redash vagrant server in …
cd36c85 
…one command.
@amasare
Revert "Kumar: Make bottom margin on visualizations editable"
8c34889 
This reverts commit 1f8b9f2.
@amasare
Ama: Consolidate vagrant_provision script, move files to more intuiti…
262ca30 
…ve locations, include command from #1021.

Also reset circle.yml to be as in the main redash repo so our changes are not included in the changeset
Check earlier PR #1027 to follow conversation.
@amasare
Ama: Install just pymongo and not everything in requirements_all_ds.txt
c4f5b5c 
Because some dependencies were missing and we dont really need everything in the file...just pymongo
Also removed unneeded files, reverted circle.yml to as it is on redash, so it doesnt show in the PR diff
@staritza staritza changed the title Vagrant flow Improve the vagrant flow May 9, 2016
@arikfr
Copy link
Member

arikfr commented May 9, 2016

Looks like you need to rebase with updated master.

arikfr
arikfr reviewed May 9, 2016
View reviewed changes
docs/dev/vagrant.rst
``vagrant up``. This might take some time the first time you run it,
3. Change dir into the repository (``cd redash``)
4a. To execute tests, run ``./run_tests.sh``
4b. To run the app, run ``./run_redash_locally.sh``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice the docs mention the old scripts and not vagrant_ctl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Good catch!

amasare added 11 commits May 9, 2016 16:31
@amasare
Ama: Add more config options for circle ci code deploy
8009da2
@amasare
Ama: Remove code deploy config. Delete uneeded docker image deploy
a436a47 
The team decided to leave the artifacts in Circle and have another pipeline which will pull the artifacts from Circle into Go.
@amasare
Ama/Kozak: Remove uneccesary docker info
4069862
@amasare
Ama/Kozak: Delete script we created. No longer needed.
7b3327a 
We are using redash's circle script which includes testing
@amasare
Kumar: Make bottom margin on visualizations editable
dc20109
@amasare
Ama/Chris #7121 Added script to run or test redash vagrant server in …
24384e9 
…one command.
@amasare
Revert "Kumar: Make bottom margin on visualizations editable"
f7b23d3 
This reverts commit 1f8b9f2.
@amasare
Ama: Consolidate vagrant_provision script, move files to more intuiti…
0a6d6ac 
…ve locations, include command from #1021.

Also reset circle.yml to be as in the main redash repo so our changes are not included in the changeset
Check earlier PR #1027 to follow conversation.
@amasare
Ama: Install just pymongo and not everything in requirements_all_ds.txt
9b7e32a 
Because some dependencies were missing and we dont really need everything in the file...just pymongo
Also removed unneeded files, reverted circle.yml to as it is on redash, so it doesnt show in the PR diff
@amasare
Ama/Kumar: Update docs to reflect use of new vagrant_ctl script
152b08c
@amasare
Merge branch 'vagrantFlow' of github.com:thoughtworks/redash into vag…
793c1e4 
…rantFlow
@staritza
Copy link
Contributor Author

staritza commented May 9, 2016 •
edited
Loading

@arikfr Please hold off on this pr for a while. We are trying to work on our team git/redash work flow.

@staritza
Copy link
Contributor Author

staritza commented May 9, 2016

@arikfr you can ignore this pr. we created this with only the commits that matter and changes to reflect your comments

@staritza staritza closed this May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@staritza @arikfr @ChrisKozak @amasare