Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v25.1 Release Plan #7251

Closed
5 tasks done
eradman opened this issue Dec 17, 2024 · 13 comments
Closed
5 tasks done

v25.1 Release Plan #7251

eradman opened this issue Dec 17, 2024 · 13 comments

Comments

@eradman
Copy link
Collaborator

eradman commented Dec 17, 2024

  • Create a release branch
  • Create new GitHub Release
  • Push image to Docker Hub
  • Update Redash website
  • Announcement in discussions/6647

References:

New-version-release-checklist
v6 Release Plan
Release Notes
Release Candidates and Release Versioning

@justinclift
Copy link
Member

We'll probably need to make sure the tag that's created doesn't have leading zero's in the month part too. ie 25.1 vs 25.01

@lucydodo
Copy link
Member

Should we write release notes?

@justinclift
Copy link
Member

@eradman has already been creating release notes in the wiki: https://github.com/getredash/redash/wiki/Release-Notes 😄

@eradman
Copy link
Collaborator Author

eradman commented Dec 19, 2024

We'll probably need to make sure the tag that's created doesn't have leading zero's in the month part too. ie 25.1 vs 25.01

Do we want to drop the leading zero? As long as we're consistent in the future either way is fine.

This is is the sequence I have in mind:

git checkout 25.01.0-dev
git checkout -b v25.1
vim package.json redash/__init__.py pyproject.toml  # set version to 25.1.0
git commit -a -m "25.1.0 release"
git push --set-upstream origin v25.1
gh release create v25.1.0 --target v25.1 --title v25.1.0 --notes "v25.1.0 release"

In this scheme any bug fixes and patches can be applied to the v25.1 branch, followed by a minor release.

@justinclift
Copy link
Member

Do we want to drop the leading zero?

Yeah, we definitely do. It has the potential (and likelihood) of causing issues with things that can't deal with leading zeros, and we don't really need to take that chance.

@arikfr Pointed out a while ago that it'll probably cause issues with older versions of Redash that are doing version checks too, so we should fix the problem before the next release.

This is is the sequence I have in mind ...

Looks good to me, nothing is immediately jumping out as wrong with that. 😄

@eradman eradman changed the title v25.01 Release Plan v25.1 Release Plan Dec 20, 2024
@eradman
Copy link
Collaborator Author

eradman commented Jan 2, 2025

Created the v25.1 branch: https://github.com/getredash/redash/tree/v25.1

Next steps I think are to create a Github release and deploy and image to Dockerhub

@eradman
Copy link
Collaborator Author

eradman commented Jan 8, 2025

Created a release, we can edit the description as needed

v25 1 0-release

Next step is to publish a Docker image

@eradman
Copy link
Collaborator Author

eradman commented Jan 8, 2025

Manually ran the Preview Image action, which succeeded in pushing the 25.1.0 image:

https://hub.docker.com/layers/redash/redash/25.1.0/images/sha256-f1eb5a2529cfcddb35d7cec37858441557620164e9899d3dd0692073769f7fd3

Pulling this image to see how it works!

eradman added a commit to eradman/redash-website that referenced this issue Jan 9, 2025
eradman added a commit to eradman/redash-website that referenced this issue Jan 9, 2025
@lucydodo
Copy link
Member

lucydodo commented Jan 9, 2025

I just merged getredash/website#812. It seems like we've completed all the checklist items—can we go ahead and close it?
Also, I want to take a moment to thank everyone who contributed to this release. :)

@eradman
Copy link
Collaborator Author

eradman commented Jan 9, 2025

It seems like we've completed all the checklist items—can we go ahead and close it?

I think so. If we'll start a new ticket for a bugfix-only minor release.

Also, I want to take a moment to thank everyone who contributed to this release. :)

I concur!

@eradman eradman closed this as completed Jan 9, 2025
@arikfr
Copy link
Member

arikfr commented Jan 14, 2025

Congrats and thank you everyone who took part in this 🙏 🎉

@ericminio
Copy link

Hi
Is the https://github.com/getredash/setup still relevant for this version?

@ericminio
Copy link

Nevermind, works well!
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants