User can't save query without query text

[arikfr]

(seems like it doesn't pass the data_source_id)

[alonho]

Can't reproduce.. I created a query, saved, it worked. Also tried creating, renaming and saving.

[arikfr]

STR:

1. Open new query.
2. Change query name.
3. Hit enter. Soon after "Can't save query" message appears.

[alonho]

I tried pressing the save button and it worked through there.

This happens because update to the name/description is considered a partial update and sets only the name/description field. When that happens and a query was just created, there's no id, so the api call that is used is 'create query' and not 'update query'. 'create query' expects a data source id.

[arikfr]

OK, it makes sense now. How about we don't try doing partial save until
query has an id?
On Nov 30, 2015 5:44 PM, "Alon Horev" notifications@github.com wrote:

I tried pressing the save button and it worked through there.

This happens because update to the name/description is considered a
partial update and sets only the name/description field. When that happens
and a query was just created, there's no id, so the api call that is used
is 'create query' and not 'update query'. 'create query' expects a data
source id.

—
Reply to this email directly or view it on GitHub
#669 (comment).