Skip to content

Commit

Permalink
Migrate Query pages to React: fix permissions (#4506)
Browse files Browse the repository at this point in the history
  • Loading branch information
kravets-levko authored Dec 29, 2019
1 parent 2484bc0 commit db82b84
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion client/app/pages/queries/components/QuerySourceAlerts.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function QuerySourceAlerts({ query, dataSourcesAvailable }) {
const queryFlags = useQueryFlags(query); // we don't use flags that depend on data source

let message = null;
if (queryFlags.isNew && !queryFlags.canCreateQuery) {
if (queryFlags.isNew && !queryFlags.canCreate) {
message = (
<React.Fragment>
<Typography.Title level={4}>
Expand Down
4 changes: 3 additions & 1 deletion client/app/pages/queries/hooks/useQueryFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ export default function useQueryFlags(query, dataSource = null) {
isArchived: query.is_archived,

// permissions flags
canEdit: query.can_edit,
canCreate: currentUser.hasPermission("create_query"),
canView: currentUser.hasPermission("view_query"),
canEdit: currentUser.hasPermission("edit_query") && query.can_edit,
canViewSource: currentUser.hasPermission("view_source"),
canExecute:
!isEmpty(query.query) &&
Expand Down

0 comments on commit db82b84

Please sign in to comment.