Skip to content

Commit

Permalink
Provide default value for .pop to avoid KeyError exception (#3474)
Browse files Browse the repository at this point in the history
  • Loading branch information
arikfr authored Feb 21, 2019
1 parent 8b19f16 commit 4999ab5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion redash/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def apply_pool_defaults(self, app, options):
if settings.SQLALCHEMY_DISABLE_POOL:
options['poolclass'] = NullPool
# Remove options NullPool does not support:
options.pop('max_overflow')
options.pop('max_overflow', None)


db = RedashSQLAlchemy(session_options={
Expand Down

0 comments on commit 4999ab5

Please sign in to comment.