Fix max-age issues on textless endpoint (#3477)

* max_age should default to -1 * pass maxAge along to `execute`
getredash · Feb 21, 2019 · 2a37cb3 · 2a37cb3
1 parent 4ad303b
commit 2a37cb3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/client/app/services/query.js b/client/app/services/query.js
@@ -501,7 +501,7 @@ function QueryResource(
   };
 
   QueryService.prototype.getQueryResult = function getQueryResult(maxAge) {
-    const execute = () => QueryResult.getByQueryId(this.id, this.getParameters().getValues());
+    const execute = () => QueryResult.getByQueryId(this.id, this.getParameters().getValues(), maxAge);
     return this.prepareQueryResultExecution(execute, maxAge);
   };
 

diff --git a/redash/handlers/query_results.py b/redash/handlers/query_results.py
@@ -194,7 +194,11 @@ def post(self, query_id):
         """
         params = request.get_json(force=True)
         parameters = params.get('parameters', {})
-        max_age = int(params.get('max_age', 0))
+        max_age = params.get('max_age', -1)
+        # max_age might have the value of None, in which case calling int(None) will fail
+        if max_age is None:
+            max_age = -1
+        max_age = int(max_age)
 
         query = get_object_or_404(models.Query.get_by_id_and_org, query_id, self.current_org)
         parameter_schema = query.options.get("parameters", [])