Skip to content

Commit

Permalink
Remove the need to declare each visualization module in app dependenc…
Browse files Browse the repository at this point in the history
…ies.
  • Loading branch information
arikfr committed Feb 16, 2014
1 parent 4aaac16 commit 1a896e9
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
3 changes: 0 additions & 3 deletions rd_ui/app/scripts/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ angular.module('redash', [
'redash.services',
'redash.renderers',
'redash.visualization',
'redash.visualization.chart',
'redash.visualization.cohort',
'redash.visualization.table',
'ui.codemirror',
'highchart',
'angular-growl',
Expand Down
2 changes: 1 addition & 1 deletion rd_ui/app/scripts/visualizations/chart.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
(function () {
var chartVisualization = angular.module('redash.visualization.chart', []);
var chartVisualization = angular.module('redash.visualization');

chartVisualization.config(['VisualizationProvider', function(VisualizationProvider) {
var renderTemplate = '<chart-renderer options="visualization.options" query-result="queryResult"></chart-renderer>';
Expand Down
2 changes: 1 addition & 1 deletion rd_ui/app/scripts/visualizations/cohort.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
(function () {
var cohortVisualization = angular.module('redash.visualization.cohort', []);
var cohortVisualization = angular.module('redash.visualization');

cohortVisualization.config(['VisualizationProvider', function(VisualizationProvider) {
VisualizationProvider.registerVisualization('COHORT', 'Cohort', '<cohort-renderer options="visualization.options" query-result="queryResult"></cohort-renderer>', null);
Expand Down
2 changes: 1 addition & 1 deletion rd_ui/app/scripts/visualizations/table.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
(function () {
var tableVisualization = angular.module('redash.visualization.table', []);
var tableVisualization = angular.module('redash.visualization');

tableVisualization.config(['VisualizationProvider', function(VisualizationProvider) {
VisualizationProvider.registerVisualization('TABLE', 'Table', '<grid-renderer options="visualization.options" query-result="queryResult"></grid-renderer>', null, {}, true);
Expand Down

0 comments on commit 1a896e9

Please sign in to comment.